Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure correct callback behavior with reusable states #4

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

definitelyokay
Copy link
Member

Reworks LogicBlocks to ensure OnEnter/OnExit is called in the correct order for states that are reused.

  • Adds support for multiple initial state types to the diagram generator
  • Adds support for partial states spread across files to the diagram generator.
  • Simplifies the LogicBlock core state change mechanism.
  • Adds internal state to StateLogic so callbacks can be preserved inside the state rather than inside the logic block. This is the mechanism which enables the fix above.
  • Updates all API usage, fixes tests, and introduces new tests for desired use cases.

@definitelyokay definitelyokay merged commit f0a27ee into main Jul 26, 2023
4 checks passed
@definitelyokay definitelyokay deleted the fix/callbacks branch July 26, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant