Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify ""Max-age > 10 years" warning #116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

clarify ""Max-age > 10 years" warning #116

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e46db1
clarify ""Max-age > 10 years" warning
teh-maxh Nov 25, 2020
cdfccb4
revision per discussion on pr
teh-maxh Nov 26, 2020
64f12d9
Merge branch 'chromium:main' into 10-year-message
teh-maxh Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion header.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func preloadableHeaderMaxAge(hstsHeader HSTSHeader) Issues {
issues = issues.addWarningf(
"header.preloadable.max_age.over_10_years",
"Max-age > 10 years",
"FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value.",
"FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value, and may be disregarded by some browsers.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording "may be disregarded" makes it sound like the browser will disregard the max-age value (and thus the HSTS header) altogether, which is not the case. How about "may be capped at a lower value" instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid concern. Revising.

hstsHeader.MaxAge.Seconds,
)

Expand Down