Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and candy generator #774

Merged

Conversation

kohlschuetter
Copy link
Contributor

@kohlschuetter kohlschuetter commented Oct 14, 2023

  • Move plugin and dependency version management to parent POM
  • Update plugins and dependencies, as checked via mvn versions:display-dependency-updates -U and mvn versions:display-plugin-updates -U
  • Require Maven 3.3.9 or newer
  • Remove unused dependencies
  • Change parser generator code from Maven Ant script to Java file
  • Add generated parses to version control, remove timestamp comments
  • Incorporate filevisitor code into candy-generator as an implementation detail

Define plugin dependency version at the top-level POM.
This is code can trivially be integrated as an implementation detail
into candy generator.

Eventually, it can be replaced by standard Java API code, but now is not
the time.
Maven dependencies should be managed centrally for the entire project.
Remove mockito-core, which wasn't used.
Previously, we were building the used parsers with an Ant script.
This was brittle, especially updating dependency versions was difficult.

Moreover, the generated files contained timestamps, which is why these
files were not included in version control.

Replace the generator builder code with a Java class that gets executed
upon Maven build.

The generator automatically transforms the output to remove all
information about the current timestamp, making it possible to include
the files in version control. This also helps checking for errors when
updating the parser generators.
Update generated parser code.
Clarify Licenses in pom.
... and replace obsoleted methods as described in jsoup
@renaudpawlak renaudpawlak merged commit c628192 into cincheo:develop Oct 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants