Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The linter workflow was configured to always pass despite any relevant warnings found. There have been situations where code that did not meet the linter's standards were merged into main. The placement of
continue-on-error
has been updated so the workflow catches relevant errors.All PowerShell warnings have been addressed except for two files which call Invoke-Expression. The change is trivial but requires additional testing of SetupTestbed.ps1/install_lme.ps1 which is out of scope for this PR. See the issue below for more info.
💭 Motivation and context
Improves our CI/CD integrations and overall testing of LME.
Resolves #175
Additional todos after this PR is merged:
🧪 Testing
Ran the main.yml Github action, checked warnings/errors from PSScriptAnalyzer and applied necessary changes.
✅ Pre-approval checklist
the title reflects this in a clear human readable format
✅ Pre-merge Checklist
✅ Post-merge Checklist