Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to the purego build tag, removing noasm build tag #492

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mattyclarkson
Copy link
Contributor

The purego build tag has been proposed1 as the de-facto tag for pure Go builds. This is a superset of the noasm tag currently used.

This patch aligns the code base to toggle to pure Go implementation when purego is defined.

Verified that all assembly is excluded by doing:

find . -name '*.s' -exec sed -i -e '$athis-is-not-valid-assembly 12345' {} \;
go test --tags purego ./...

Closes #491

@mattyclarkson
Copy link
Contributor Author

RFC: @armfazh from discussion on #491

The `purego` build tag has been proposed[1] as the de-facto tag for
pure Go builds. This is a superset of the `noasm` tag currently used.

This patch aligns the code base to toggle to pure Go implementation
when `purego` is defined.

Verified that all assembly is excluded by doing:

    find . -name '*.s' -exec sed -i -e '$athis-is-not-valid-assembly 12345' {} \;
    go test --tags purego ./...

[1]: golang/go#23172
@mattyclarkson
Copy link
Contributor Author

@armfazh would it be possible to get approval to run the CI on this PR? Thanks.

@armfazh armfazh merged commit 2c600ff into cloudflare:main Apr 8, 2024
10 checks passed
@armfazh
Copy link
Contributor

armfazh commented Apr 8, 2024

Thanks @mattyclarkson for reporting.

@mattyclarkson
Copy link
Contributor Author

@armfazh would it be possible to get this in a 1.3.8 release? No pressure, we can patch locally. If there are other things in flight on mainline before the next release, happy to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align on purego build tag.
2 participants