fixed syntax based on shellcheck (#27) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root360-AndreasUlm
force-pushed
the
linting_run.sh
branch
from
16ae84b
to
4a40270
Compare
|
rebased branch |
Fixed issues reported by shellcheck (https://github.com/koalaman/shellcheck/wiki) to improve security and POSIX shell interoperability. (part of cloudflare#27) Signed-off-by: Andreas Ulm <[email protected]>
root360-AndreasUlm
force-pushed
the
linting_run.sh
branch
from
4a40270
to
aaf0e38
Compare
|
rebased branch to latest master |
| @@ -1,7 +1,8 @@ | |||
| #!/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I believe this will break unless bash is added to the image.
$ git diff run.sh
diff --git a/run.sh b/run.sh
index dcbcdf2..a8833ca 100755
--- a/run.sh
+++ b/run.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
current_time=$(date "+%Y.%m.%d-%H.%M")
if [[ -z $upload ]]
$ docker run -ti --entrypoint=/bin/sh flan_scan
/ # ls -l /bin/bash
ls: /bin/bash: No such file or directory
/ # exit
$ make html
docker run --name flan_1585682201 -v "xxx/Github/flan/shared:/shared:Z" -e format=html flan_scan
standard_init_linux.go:211: exec user process caused "no such file or directory"
make: *** [html] Error 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues reported by shellcheck (https://github.com/koalaman/shellcheck/wiki) to improve security and POSIX shell interoperability.
(part of #27)