Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tex to pdf convert #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christian-korneck
Copy link

a report pdf file gets created and uploaded alongside the tex file
Fixes #8

This was referenced Nov 28, 2019
@sir-ragna
Copy link

I tested it and it works. 👍

There does seem to be a significant size increase. From 196MB to 3.09GB. For automatic deployments that regularly rebuild because you want the latest nmap-scripts, I think this might start to add up.

On one hand I really want this in the repo and on the other hand I feel like it might not be suitable as a default. Here's an idea. What about putting this in a separate container specifically building the reports. Create a separate Dockerfile that can be build and run from the same Makefile. The advantages would be that:

  • building it becomes optional;
  • rebuilds can be optimized so more layers are shared with previous builds.
  • It can also include xsltproc and the commands to conver the xml to html reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML or direct PDF output
2 participants