Add Azure storage account upload support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding feature for Azure storage uploading.
|
Just my random 2 cents. This could be done without bringing in Azure dependencies. With a shared access signature URL files can be saved in storage accounts with a plain old PUT request. Additionally, it means you can created a SAS token with only access to write new blobs without needing the storage account key with full access. It could also done in a generic way that supports POST or PUT to any URL. |
|
@coderpatros I don't personally think the fact the change utilises Azure dependencies matters? The existing AWS and GCP exports both have dependencies on their retrospective CLI tools. |
|
@jusso-dev Just putting it out there that a bunch of extra bundled code, in the form of dependencies, could be dropped with a few lines of standard library code. |
SjamonDaal
approved these changes
Aug 6, 2020
SjamonDaal
reviewed
Aug 6, 2020
Cloudflare master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for uploading scan reports to Azure storage accounts.
The primary downside to this change is that the Azure python packages have a dependency on cffi, which performs a compile when installed in alpine. Thus, it requires gcc and some other support libraries to complete installation.
build-baseis removed again after the pip installations complete.