Merge pull request #2703 from cloudflare/jsnell/make-eventsource-exte…

…nd-eventtarget
cloudflare · Sep 12, 2024 · bd2c90e · bd2c90e
2 parents 71ed2a6 + 8492c5a
commit bd2c90e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/workerd/api/eventsource.h b/src/workerd/api/eventsource.h
@@ -163,6 +163,7 @@ class EventSource: public EventTarget {
   }
 
   JSG_RESOURCE_TYPE(EventSource) {
+    JSG_INHERIT(EventTarget);
     JSG_METHOD(close);
     JSG_READONLY_PROTOTYPE_PROPERTY(url, getUrl);
     JSG_READONLY_PROTOTYPE_PROPERTY(withCredentials, getWithCredentials);

diff --git a/src/workerd/api/tests/eventsource-test.js b/src/workerd/api/tests/eventsource-test.js
@@ -9,6 +9,7 @@ export const acceptEventStreamTest = {
       'http://example.org/accept-event-stream',
       { fetcher: env.subrequest }
     );
+    ok(eventsource instanceof EventTarget);
     strictEqual(eventsource.readyState, EventSource.CONNECTING);
     const { promise, resolve } = Promise.withResolvers();
     let opened = false;