remove unnecessary mutex guard

cloudflare · Aug 21, 2024 · d482047 · d482047
1 parent e3fe79c
commit d482047
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/workerd/api/node/zlib-util.c++ b/src/workerd/api/node/zlib-util.c++
@@ -108,7 +108,7 @@ kj::Maybe<CompressionError> ZlibContext::setDictionary() {
 }
 
 bool ZlibContext::initializeZlib() {
-  if (initialized.lockExclusive()) {
+  if (initialized) {
     return false;
   }
   switch (mode) {
@@ -134,7 +134,7 @@ bool ZlibContext::initializeZlib() {
   }
 
   setDictionary();
-  *initialized.lockExclusive() = true;
+  initialized = true;
   return true;
 }
 
@@ -284,7 +284,7 @@ kj::Maybe<CompressionError> ZlibContext::setParams(int _level, int _strategy) {
 }
 
 void ZlibContext::close() {
-  if (!initialized.lockExclusive()) {
+  if (!initialized) {
     dictionary.clear();
     mode = ZlibMode::NONE;
     return;

diff --git a/src/workerd/api/node/zlib-util.h b/src/workerd/api/node/zlib-util.h
@@ -10,7 +10,6 @@
 #include "zlib.h"
 #include <kj/array.h>
 #include <kj/compat/brotli.h>
-#include <kj/mutex.h>
 #include <kj/vector.h>
 
 #include <cstdlib>
@@ -142,7 +141,7 @@ class ZlibContext final {
     return {kj::str(message), kj::str(ZlibStrerror(err)), err};
   };
 
-  kj::MutexGuarded<bool> initialized{false};
+  bool initialized = false;
   ZlibMode mode = ZlibMode::NONE;
   int flush = Z_NO_FLUSH;
   int windowBits = 0;