Fix GC visitation in stream readers and writers #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byule
approved these changes
Feb 1, 2024
kentonv
force-pushed
the
kenton/streams-gc-visit-fix
branch
from
d01aff1
to
1ad3252
Compare
|
Missed some instances of the teardown bug, discovered when I ran more tests. Updated. |
kentonv
added a commit
that referenced
this pull request
Feb 5, 2024
kentonv
added a commit
that referenced
this pull request
Feb 6, 2024
Fix two spots I missed in #1606.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in certain uses of streams.
This is a simpler version of #1598. I was able to directly fix the problem that the WeakRef refactor also solved.