Limit alarm handler walltime to 15minutes #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
from
83fa87a
to
2d5ce68
Compare
jclee
reviewed
Feb 5, 2024
jclee
reviewed
Feb 6, 2024
dom96
approved these changes
Feb 6, 2024
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
2 times, most recently
from
1932198
to
8d3d366
Compare
|
Updated PR with new expected behaviour where alarms will be deleted after 1 run + 6 retries.
|
justin-mp
requested changes
Feb 6, 2024
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
from
8d3d366
to
71ea6db
Compare
|
Updated PR with timeout as |
justin-mp
reviewed
Feb 6, 2024
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
3 times, most recently
from
2a7afc0
to
dd52149
Compare
|
Updated PR:
|
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
from
dd52149
to
4e03280
Compare
justin-mp
approved these changes
Feb 7, 2024
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
from
4e03280
to
ddbde5c
Compare
a-robinson
approved these changes
Feb 7, 2024
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
2 times, most recently
from
6d13fe7
to
2f914a8
Compare
jqmmes
force-pushed
the
joaquim/alarm-handler-walltime-15m-limit
branch
from
2f914a8
to
3f6584b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a wall time timeout for alarm handlers.
When the timeout for an alarm it hit, we cancel deferred alarm deletion and abort the currently running handler.
The alarm timeouts are counted against limits, so they get deleted once the maximum retry limit is reached.