Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store alarm value in sqlite database, for sqlite-backed DOs #2648

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Store alarm value in sqlite database, for sqlite-backed DOs #2648

merged 4 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. actor alarms tests: Reject waiting promise on alarm handler exception 

    Exceptions that escape from the alarm handler don't cause the test to fail, so
a failing assertion in the alarm handler only caused the test to hang.  Calling
the reject function of the waiting promise on exception should avoid this.

Also tightening up the nullness checks.
    @jclee
    jclee committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4a87433 View commit details
    Browse the repository at this point in the history

  2. ActorSqlite: Revise armAlarmHandler() to allow for waiting before can… 

    …cellation
    @jclee
    jclee committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    49f408c View commit details
    Browse the repository at this point in the history

  3. Add SqliteMetadata helper class for reading/writing sqlite alarm time 

    Analogous to SqliteKv helper class; not used yet.
    @jclee
    jclee committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    66d1f2f View commit details
    Browse the repository at this point in the history

  4. sqlite actor alarms: store alarm time in sqlite 

    Also, enforce similar alarm properties in ActorSqlite as we do in ActorCache.
    @jclee
    jclee committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4f9e6aa View commit details
    Browse the repository at this point in the history