fix invalid invocation on getRandomValues() #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/fix-getrandombytes
branch
2 times, most recently
from
3eda8c8
to
1af6beb
Compare
anonrig
force-pushed
the
yagiz/fix-getrandombytes
branch
from
1af6beb
to
e54450b
Compare
anonrig
force-pushed
the
yagiz/fix-getrandombytes
branch
from
e54450b
to
8b358ec
Compare
| async test() { | ||
| const crypto = await import('node:crypto'); | ||
| { | ||
| // The following assertion doesn't fail as of Node.js v20.17.0 |
There was a problem hiding this comment.
This doesn't fail for me in node 18 either...
petebacondarwin
approved these changes
Sep 17, 2024
|
thank you @anonrig!! |
dom96
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2716