Add lock wait time metrics for Memory Cache. #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-cf
force-pushed
the
mar/memory-cache-lwt
branch
from
5a27a61
to
9cf0483
Compare
mar-cf
requested review from
garrettgu10
and removed request for
garrettgu10
mikea
reviewed
Sep 24, 2024
mar-cf
commented
Sep 25, 2024
mar-cf
force-pushed
the
mar/memory-cache-lwt
branch
from
d1382b7
to
1989984
Compare
mikea
reviewed
Sep 26, 2024
mar-cf
force-pushed
the
mar/memory-cache-lwt
branch
from
1989984
to
0aee910
Compare
mikea
approved these changes
Sep 26, 2024
src/workerd/api/memory-cache.c++
Outdated
| const kj::String& key, SpanBuilder& span) const { | ||
| kj::Locked<ThreadUnsafeData> data = [&] { | ||
| auto memoryCacheLockRecord = | ||
| ScopedDurationTagger(span, "memory_cache_lock_wait_time_ns"_kjc, cache->timer); |
There was a problem hiding this comment.
since this is used twice lets extract single constexpr memoryCachekLockWaitTimeTag = ...
Use timer directly in memory cache lock record and write tag directly to span.
mar-cf
force-pushed
the
mar/memory-cache-lwt
branch
from
0aee910
to
76a905c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.