[nfc] wd_capnp_library - capnp libraries for multiple languages #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
force-pushed
the
maizatskyi/2024-09-24-capnp-rust
branch
6 times, most recently
from
3368ae7
to
ac7c589
Compare
mikea
changed the title
mikea
force-pushed
the
maizatskyi/2024-09-24-capnp-rust
branch
from
ac7c589
to
61c359f
Compare
wd_capnp_library generates both c++ and rust versions
mikea
force-pushed
the
maizatskyi/2024-09-24-capnp-rust
branch
from
61c359f
to
1ca74bb
Compare
fhanau
reviewed
Sep 30, 2024
| visibility = visibility, | ||
| deps = deps, | ||
| srcs = [src], | ||
| tags = ["manual"] + tags, |
There was a problem hiding this comment.
So far this is implicitly tagged as "off-by-default" based on the cc_capnp_library definition – manual is probably fine though, glad we are managing this for Rust too so that we only build the rust wrapper crates when they are being used.
fhanau
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a given file-name.capnp it will produce:
file-name_capnpc++ libraryfile-name_capnp_rustrust libraryMakes definining and managing capnp libraries simpler.