Simplify pages download config

[penalosa]

What this PR solves / how to test

Simplifies the config file downloaded by wrangler pages download config:

• If preview and production are currently equal, don't generate a production override
• Don't include inheritable keys in the production override if they're equal to production

Fixes DEVX-1245
Fixes DEVX-1245

Author has addressed the following

• Tests
  • TODO (before merge)
  • Included
  • Not necessary because:
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Included
  • Not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
  • Not necessary because: No change to documented behaviour

[changeset-bot]

🦋 Changeset detected

Latest commit: a7544a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-wrangler-5569

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5569/npm-package-wrangler-5569

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-wrangler-5569 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-create-cloudflare-5569 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-cloudflare-kv-asset-handler-5569

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-miniflare-5569

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-cloudflare-pages-shared-5569

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9797569837/npm-package-cloudflare-vitest-pool-workers-5569

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240701.0
workerd	1.20240701.0	1.20240701.0
workerd --version	1.20240701.0	2024-07-01

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[petebacondarwin]

Marking as request changes because I think it would be good to have a discussion and resolution of the behaviour before we land this, not because I am insisting that we change the behaviour.

[petebacondarwin]

@penalosa - can you follow up on this PR and address my comments?

[petebacondarwin]

I am a bit concerned about this logic (that find inheritable props to deduplicate and that handles the props that cannot be removed from an environment - e.g. limits) is hidden inside this function.

What happens when someone adds a new inheritable field to the configuration in the future. How are they goingt to know that they must come here and update this logic?

Could we consider making this a bit more declarative? Perhaps having a list of such properties in the config/environment.ts file where these aspects are defined and then this code would just generically use that list without having to hard code properties in here.

[penalosa]

We discussed this offline, and decided to stay roughly with this approach for now, since the exceptions aren't super generic