Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarantine C3 astro e2e test #6139

Merged
merged 1 commit into from
Jun 25, 2024
Merged

quarantine C3 astro e2e test #6139

merged 1 commit into from
Jun 25, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jun 24, 2024

What this PR solves / how to test

C3 astro e2e test started failing in CI for no obvious reasons since Mon 24 June 2024. We tried everything, like increasing timeouts, debugging, reproducing locally (which we can't) to no avail. We are quite confident that the test failures are not caused by any changes in wrangler (we verified this by running the tests against a PR where they were consistently green, but did fail on the re-run, without any changes to the branch).

As this is blocking our release, we decided to quarantine these tests, do the release, while continuing to look into why the tests are failing.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner June 24, 2024 18:46
Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: f4c7a9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-wrangler-6139

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6139/npm-package-wrangler-6139

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-wrangler-6139 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-create-cloudflare-6139 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-cloudflare-kv-asset-handler-6139
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-miniflare-6139
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-cloudflare-pages-shared-6139
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9660938980/npm-package-cloudflare-vitest-pool-workers-6139

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/e2e branch 2 times, most recently from a7e8abc to 34b6c20 Compare June 24, 2024 19:23
@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner June 24, 2024 19:23
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/e2e branch 2 times, most recently from f80da56 to 249004d Compare June 25, 2024 09:22
C3 astro e2e test started failing in CI for no
obvious reasons since Mon 24 June 2024. We
tried everything, like increasing timeouts,
debugging, reproducing locally (which we can't)
to no avail. We are quite confident that the test
failures are not caused by any changes in wrangler
(we verified this by running the tests against a PR
where they were consistently green, but did fail on
the re-run).

As this is blocking our release, we decided to
quarantine these tests, do the release, while continuing
to look into why the tests are failing.
@CarmenPopoviciu CarmenPopoviciu changed the title test quarantine C3 astro e2e test Jun 25, 2024
@petebacondarwin petebacondarwin merged commit f465471 into main Jun 25, 2024
24 checks passed
@petebacondarwin petebacondarwin deleted the carmen/e2e branch June 25, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants