Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: Add --output-logs=new-only to e2e script #6209

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jul 5, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@penalosa penalosa requested a review from a team as a code owner July 5, 2024 14:27
Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: b2ded52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa added the e2e Run e2e tests on a PR label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-wrangler-6209

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6209/npm-package-wrangler-6209

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-wrangler-6209 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-create-cloudflare-6209 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-cloudflare-kv-asset-handler-6209
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-miniflare-6209
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-cloudflare-pages-shared-6209
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9838136389/npm-package-cloudflare-vitest-pool-workers-6209

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240701.0
workerd 1.20240701.0 1.20240701.0
workerd --version 1.20240701.0 2024-07-01

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor

The Windows E2E is consistently failing. Perhaps this optimization is one step too far?
Instead, to keep the logs cleaner we could go with --output-logs=new-only?

@petebacondarwin petebacondarwin merged commit aa0aa47 into main Jul 8, 2024
20 checks passed
@petebacondarwin petebacondarwin deleted the penalosa/granular-e2e-caching branch July 8, 2024 20:41
@petebacondarwin petebacondarwin changed the title fixup: Add --only to e2e script fixup: Add --output-logs=new-only to e2e script Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants