Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

[proto] having gRPC service names PascalCase'd and others. #511

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions protocols/protocol/cloudstate/action.proto
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ service ActionProtocol {
// The input command will contain the service name, command name, request metadata and the command
// payload. The reply may contain a direct reply, a forward or a failure, and it may contain many
// side effects.
rpc handleUnary(ActionCommand) returns (ActionResponse) {}
rpc HandleUnary(ActionCommand) returns (ActionResponse) {}

// Handle a streamed in command.
//
Expand All @@ -89,7 +89,7 @@ service ActionProtocol {
//
// Either the client or the server may cancel the stream at any time, cancellation is indicated
// through an HTTP2 stream RST message.
rpc handleStreamedIn(stream ActionCommand) returns (ActionResponse) {}
rpc HandleStreamedIn(stream ActionCommand) returns (ActionResponse) {}

// Handle a streamed out command.
//
Expand All @@ -100,7 +100,7 @@ service ActionProtocol {
//
// Either the client or the server may cancel the stream at any time, cancellation is indicated
// through an HTTP2 stream RST message.
rpc handleStreamedOut(ActionCommand) returns (stream ActionResponse) {}
rpc HandleStreamedOut(ActionCommand) returns (stream ActionResponse) {}

// Handle a full duplex streamed command.
//
Expand All @@ -127,6 +127,6 @@ service ActionProtocol {
//
// Either the client or the server may cancel the stream at any time, cancellation is indicated
// through an HTTP2 stream RST message.
rpc handleStreamed(stream ActionCommand) returns (stream ActionResponse) {}
rpc HandleStreamed(stream ActionCommand) returns (stream ActionResponse) {}

}
2 changes: 1 addition & 1 deletion protocols/protocol/cloudstate/crdt.proto
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ service Crdt {
//
// The user function must respond with one reply per command in. They do not necessarily have to be sent in the same
// order that the commands were sent, the command ID is used to correlate commands to replies.
rpc handle(stream CrdtStreamIn) returns (stream CrdtStreamOut);
rpc Handle(stream CrdtStreamIn) returns (stream CrdtStreamOut);
}

// Message for the Crdt handle stream in.
Expand Down
4 changes: 2 additions & 2 deletions protocols/protocol/cloudstate/entity.proto
Original file line number Diff line number Diff line change
Expand Up @@ -308,11 +308,11 @@ message ProxyInfo {
service EntityDiscovery {

// Discover what entities the user function wishes to serve.
rpc discover(ProxyInfo) returns (EntitySpec) {}
rpc Discover(ProxyInfo) returns (EntitySpec) {}

// Report an error back to the user function. This will only be invoked to tell the user function
// that it has done something wrong, eg, violated the protocol, tried to use an entity type that
// isn't supported, or attempted to forward to an entity that doesn't exist, etc. These messages
// should be logged clearly for debugging purposes.
rpc reportError(UserFunctionError) returns (google.protobuf.Empty) {}
rpc ReportError(UserFunctionError) returns (google.protobuf.Empty) {}
}
2 changes: 1 addition & 1 deletion protocols/protocol/cloudstate/event_sourced.proto
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,5 @@ service EventSourced {
// message. The entity should reply in order, and any events that the entity requests to be
// persisted the entity should handle itself, applying them to its own state, as if they had
// arrived as events when the event stream was being replayed on load.
rpc handle(stream EventSourcedStreamIn) returns (stream EventSourcedStreamOut) {}
rpc Handle(stream EventSourcedStreamIn) returns (stream EventSourcedStreamOut) {}
}
2 changes: 1 addition & 1 deletion protocols/protocol/cloudstate/value_entity.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ service ValueEntity {
// to the entity. The entity is expected to reply to each command with exactly one reply message.
// The entity should process commands and reply to commands in the order they came
// in. When processing a command the entity can read and persist (update or delete) the state.
rpc handle(stream ValueEntityStreamIn) returns (stream ValueEntityStreamOut) {}
rpc Handle(stream ValueEntityStreamIn) returns (stream ValueEntityStreamOut) {}
}

// Input message type for the gRPC stream in.
Expand Down