Feature/metadata #461
Draft
Feature/metadata #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuetloo
commented
Mar 1, 2022
contracts/tests/recipientRegistry.ts
Outdated
| registry.connect(requester).removeRecipient(recipientId) | ||
| registry | ||
| .connect(challenger) | ||
| .removeRecipient(recipientId, { value: baseDeposit }) | ||
| ).to.be.revertedWith('Ownable: caller is not the owner') |
There was a problem hiding this comment.
@daodesigner, should these test failure fixes be moved to a different PR since it's not related to this PR and it might be easier for code review? I only found out about this because I added UniversalRecipientRegistry and added similar test cases based on OptimisticRecipientRegistry which also failed.
This was
linked to
issues
Mar 1, 2022
subgraph mapping for UniversalRecipientRegistry
yuetloo
force-pushed
the
feature/metadata
branch
from
e9af49f
to
a78a430
Compare
Allow recipient registry owner to add recipients for simple recipient registry type
Add email form for recipient registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates with the metadata registry, introduced changes
This PR closes #446, #450, #451, #458
An instance of the web app is deployed here: https://green-pine-7692.on.fleek.co/#/
FundingRoundFactory on rinkeby-arbitrum:
https://testnet.arbiscan.io/address/0x638cb73818cc3477679a996a8c37d1b23acf8974#readContract