Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rerunable tally task #706

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Add rerunable tally task #706

merged 7 commits into from
Aug 2, 2023

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Aug 2, 2023

Previous, if the tally script was stopped in the middle due to error, it cannot be resumed after the error was corrected. This task allows the tally task to resume by passing 2 additional parameters: --maci-logs and --maci-state-file

@yuetloo yuetloo self-assigned this Aug 2, 2023
auryn-macmillan
auryn-macmillan approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, Loo.
I like that it's a task now, and the ability to pass in the maci state file is a lifesaver for when things timeout unexpectedly.

@yuetloo yuetloo merged commit aa213de into develop Aug 2, 2023
2 checks passed
@yuetloo yuetloo deleted the fix/rerunable-tally branch August 2, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees

@yuetloo yuetloo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuetloo @auryn-macmillan