Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube CNES 3.1.0 doesn't contain CNES quality profile and quality gate #45

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Turiok
Copy link

@Turiok Turiok commented Jan 12, 2024

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

I make a loop to verify the HTTP code to be 200

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@Turiok
Copy link
Author

Turiok commented Jan 12, 2024

There already have tests to check the content of quality gate and quality profiles in the python. I don't have the result of your CI to know why it doesn't failed the new image (3.1.0) for this bug?

@louisjdmartin louisjdmartin added this to the 3.1.1 milestone Jan 12, 2024
@louisjdmartin louisjdmartin self-assigned this Feb 8, 2024
@louisjdmartin louisjdmartin added the enhancement New feature or request label Feb 8, 2024
@louisjdmartin louisjdmartin modified the milestones: 3.1.1, 3.1.2, 3.2.1, 3.2.2 Feb 13, 2024
@Topin2001 Topin2001 modified the milestones: 3.2.2, 3.2.3 Apr 16, 2024
@Topin2001 Topin2001 removed this from the 3.2.3 milestone Apr 24, 2024
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarQube CNES 3.1.0 doesn't contain CNES quality profile and quality gate
3 participants