Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: range keys are not supported in external files #3287

Open
RaduBerinde opened this issue Feb 9, 2024 · 0 comments
Open

db: range keys are not supported in external files #3287

RaduBerinde opened this issue Feb 9, 2024 · 0 comments
Assignees
@RaduBerinde
Labels
A-storage T-storage
Projects
(Deprecated) Storage

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Feb 9, 2024 •
edited by cockroach-jira-scripts
Loading

If we use IngestExternalFiles with a file that has range keys, we can get incorrect results. This is because some iterators (like keyspan.LevelIter) assume that range key boundaries are tight (and HasRangeKeys is accurate). These assumptions don't hold in general for external files.

Jira issue: PEBBLE-114
@RaduBerinde RaduBerinde self-assigned this Feb 9, 2024
@RaduBerinde RaduBerinde added this to Incoming in (Deprecated) Storage via automation Feb 9, 2024
@itsbilal itsbilal moved this from Incoming to Backlog in (Deprecated) Storage Feb 20, 2024
@RaduBerinde RaduBerinde self-assigned this Jul 6, 2024
RaduBerinde added a commit to RaduBerinde/pebble that referenced this issue Jul 8, 2024
@RaduBerinde
db: support range keys in external files
74eab17 
We now support range keys in external files, and we support synthetic
prefix for range keys. We don't yet support synthetic suffix.

Informs cockroachdb#3287
@RaduBerinde RaduBerinde mentioned this issue Jul 8, 2024
Merged
RaduBerinde added a commit to RaduBerinde/pebble that referenced this issue Jul 10, 2024
@RaduBerinde
db: support range keys in external files
b6de252 
We now support range keys in external files, and we support synthetic
prefix for range keys. We don't yet support synthetic suffix.

Informs cockroachdb#3287
RaduBerinde added a commit that referenced this issue Jul 15, 2024
@RaduBerinde
db: support range keys in external files
b6c49f4 
We now support range keys in external files, and we support synthetic
prefix for range keys. We don't yet support synthetic suffix.

Informs #3287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

Labels
A-storage T-storage
Projects
Storage
Status: In Progress (this milestone)
(Deprecated) Storage
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RaduBerinde