db: support range keys in external files #3737
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itsbilal)
| . | ||
|
|
||
| ingest-external | ||
| points-and-ranges.sst synthetic-prefix=x_ bounds=(x_a,x_d) has-range-keys |
There was a problem hiding this comment.
Let's try adding a case where the last key is the rangedel's end key, and yet we're at a loose bound? So something like [a, c2) for the vsst bounds.
This change improves the data-driven LevelIter test and simplfies the code. Instead of specifying point keys, we allow extending either point key or range key bounds directly.
We now support range keys in external files, and we support synthetic prefix for range keys. We don't yet support synthetic suffix. Informs cockroachdb#3287
RaduBerinde
force-pushed
the
range-keys-external
branch
from
74eab17
to
b6de252
Compare
There was a problem hiding this comment.
TFTRs!
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itsbilal)
testdata/ingest_external line 1033 at r3 (raw file):
Previously, itsbilal (Bilal Akhtar) wrote…
Let's try adding a case where the last key is the rangedel's end key, and yet we're at a loose bound? So something like
[a, c2)for the vsst bounds.
Done.
|
TFTRs! |
keyspan: modernize the LevelIter test
This change improves the data-driven LevelIter test and simplfies the
code. Instead of specifying point keys, we allow extending either
point key or range key bounds directly.
keyspan: add LevelIter tests with loose range key spans
db: support range keys in external files
We now support range keys in external files, and we support synthetic
prefix for range keys. We don't yet support synthetic suffix.
Informs #3287