Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Formatter #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated Formatter #7

wants to merge 3 commits into from

Conversation

shettytejas
Copy link

@shettytejas shettytejas commented May 13, 2023 •
edited
Loading

I was making a Github Actions project for working with SimpleCov. Turns out this being the recommended gem by SimpleCov, didn't have some functionalities I was thinking of adding support for. So added it here in this PR. If you have any thoughts or suggestions do let me know 馃槃

What's Changed:

  • Minimum Coverage Check for file. If fails, the file name and the percent_covered is collected in errors.
  • Groups now contain more information such as covered_lines, missed_lines and total_lines.
  • Also returns config details like minimum_coverage and minimum_coverage_by_file.
  • Total metrics as default (even when groups are not available).

@shettytejas shettytejas changed the title Updated formatter Updated Formatter May 13, 2023
@shettytejas shettytejas marked this pull request as draft May 13, 2023 20:39
@shettytejas shettytejas marked this pull request as ready for review May 13, 2023 20:51
pboling
pboling approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rslhdyt
Copy link

rslhdyt commented Oct 24, 2023

This is what I need 馃殌

@eggplants
Copy link
Contributor

@fede-moya Please review this 馃檹

@pboling
Copy link
Contributor

pboling commented Mar 8, 2024

It seems like this organization needs more maintainers!

@fede-moya
Copy link
Collaborator

Hey folks!, I'm sorry. I'll try to review this one over the weekend.

@shettytejas
Copy link
Author

@fede-moya were you able to review this?

@shettytejas
Copy link
Author

@fede-moya

image

@fede-moya
Copy link
Collaborator

Hey, sorry, I'm a little busy at the moment I'll get here ASAP thanks for the reminder @shettytejas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shettytejas @rslhdyt @eggplants @pboling @fede-moya