TimeDependent belongs_to replaced_by association should be optional for rails5.2 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add required Ruby version - Add License - Add required Rails version - Add deprecation warning for breaking changes
Rails 5.2 will be supported in the next major version
|
I don't fully understand why the test are failling for only 2 Gemfiles. Is it specific to this PR (i.e. did I introduce a bug) or already present ? |
…gemspec' into belongs_to_for_time_dependent_is_optional
|
The merge of the other PR #80 fix the travis CI. Is it possible to merge it upstream and release it on rubygems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the rails 5 update, belongs_to association are require by default.
When trying to upgrade a rails 4 to rails 5 app with invoicing, InvoicingTaxRate failed due to this issue.
I think this PR fix it.
It should also fix #58