Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gitlab variable masking #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support Gitlab variable masking #19

wants to merge 3 commits into from

Commits on Nov 25, 2022

  1. Support masking directly in the gitlab-runner-rs crate 

    This brings in a dependency on the mask crate. The code to support
masking artifacts will come later. This only masks the logs passed to
Gitlab.
    @eds-collabora
    eds-collabora committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    fdc0b69 View commit details
    Browse the repository at this point in the history

  2. Add a test for log masking 

    This is only a basic test that the masking is in fact being applied to
variables marked as masked. This is not a test of the functionality of
the masking crate, only of its integration into this crate.
    @eds-collabora
    eds-collabora committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    6cd41e5 View commit details
    Browse the repository at this point in the history

  3. Allow client crates to upload masked files 

    Although we already automatically mask the trace sent to Gitlab, some
runners will produce additional log files or metadata, which must also
be masked to prevent secrets from being revealed in the artifact data.

This permits client crates to identify a file they wish to upload as
additionally requiring masking.

Note that the version bump in the masker crate is because we now need
to be able to clone the masker for each Uploader to use.
    @eds-collabora
    eds-collabora committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    e4d8dce View commit details
    Browse the repository at this point in the history