cwl v1.3.0-dev1 native loop support #1779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
cwl-v1.3
branch
from
8e78125
to
52710a1
Compare
mr-c
requested changes
Dec 26, 2022
There was a problem hiding this comment.
Huzzah!
You'll also need to add a dump of the v1.3.0-dev1 schema to https://github.com/common-workflow-language/cwltool/tree/cwl-v1.3/cwltool/schemas
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
===========================================
- Coverage 83.84% 54.85% -29.00%
===========================================
Files 46 46
Lines 8245 8266 +21
Branches 2190 2105 -85
===========================================
- Hits 6913 4534 -2379
- Misses 855 3195 +2340
- Partials 477 537 +60 ☔ View full report in Codecov by Sentry. |
mr-c
requested changes
Dec 30, 2022
cwltool/update.py
Outdated
| "The `cwltool:Loop` clause is not compatible with the `when` directive." | ||
| ) | ||
| if "loopWhen" not in r: | ||
| raise SourceLine( |
cwltool/update.py
Outdated
| ) | ||
| cls = cast(str, r["class"]) | ||
| if cls in rewrite: | ||
| r["class"] = rewrite[cls] |
schema-salad catches that before the updater runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts the logic introduced to handle the
cwltool:Looprequirement extension to handle the newloopconstruct introduced in the CWL v1.3 spec.A proper method in the
upgrade.pymodule handles the automatic conversion from the old requirement to the new format.The existing
test_loop.pyfile is still useful to verify the correctness of the conversion process.See also common-workflow-language/cwl-v1.3#5