Pass a PathMapper to the function that computes checksums #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Bruno, |
kinow
force-pushed
the
pass-pathmapper-to-checksum-fn
branch
from
beaeccc
to
afe65cb
Compare
…resolve files downloaded for instance
kinow
force-pushed
the
pass-pathmapper-to-checksum-fn
branch
from
afe65cb
to
415c492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1828
I believe without the pathmapper we get a staged dir location that may not exist, resulting in the error reported in the issue. There is at least one other function in the visitors that take a pathmapper (I think the check_permissions?), so I did something similar to resolve the actual file so that we can access its stats when checking its hash.
@bartns if you could test this PR that'd be grand, but I'm still going to wait for someone else with more experience in this part of the code to review before adding tests (or fixing any test that may be broken after this change).
Cheers,
Bruno