Bug/uar 1282 confirmation dialog logs name in logs #1194
Conversation
AndreKramer7654
changed the title
AndreKramer7654
requested review from
cdrainCH,
corybudd-ch and
stephanie-ch
AndreKramer7654
changed the title
| if (value === undefined) { | ||
| throw new Error("Are you sure you want to remove " + req.body['boMoName'] + "?"); | ||
| throw new Error("Are you sure you want to remove confirm has no value"); |
There was a problem hiding this comment.
this error message doesn't really make sense to me .. has it been run past UI/Product teams?
There was a problem hiding this comment.
I don't think we run service errors past product. How about "Are you sure you want to remove confirmation has no beneficial owner or managing officer"
There was a problem hiding this comment.
The validation middleware uses that message for the GOVUK error summary it displays to the user though, for example I just tried here:
So it would have to be a product decision to change that
There was a problem hiding this comment.
Added to ticket.
There was a problem hiding this comment.
asked Mathew to review strings. But ticket unlikely to be pulled in now :-(
There was a problem hiding this comment.
And pushed change to "Are you sure you want to remove beneficial owner or managing officer"
|
The ticket number linked doesn't appear to be the correct ticket? Let's make sure that the UI change was agreed with Gurur as I had chats with Jeremy about this ticket and heard nothing concrete back. |
AndreKramer7654
changed the title
|
SonarQube Quality Gate
|
JIRA link
https://companieshouse.atlassian.net/browse/UAR-1282
Change description
Don't include the bo or mo name in page title as that is logged by analytics.
Don't include the bo or mo name in Error raised in case that is logged.
Work checklist
Merge instructions
We are committed to keeping commit history clean, consistent and linear. To achieve this, this commit should be structured as follows:
and contain the following structural elements:
BREAKING CHANGE:introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,fix:andfeat:are allowed, for examplebuild:,chore:,ci:,docs:,style:,refactor:,perf:,test:, and others,BREAKING CHANGE: <description>may be provided.