Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/CC-2559: Save sold land filter option to database #1439

Closed

Conversation

mwejuli-ch
Copy link
Contributor

JIRA link

https://companieshouse.atlassian.net/browse/ROE-2559

Change description

  • Save sold land filter option to database
  • Refactors getApplicationData method to fetch data from API
  • Refactors all methods/objects making calls to promisified functions to use async/ await

Work checklist

  • Tests added where applicable
  • UI changes meet accessibility criteria

Merge instructions

We are committed to keeping commit history clean, consistent and linear. To achieve this, this commit should be structured as follows:

<type>[optional scope]: <description>

and contain the following structural elements:

  • fix: a commit that patches a bug in your codebase (this correlates with PATCH in semantic versioning),
  • feat: a commit that introduces a new feature to the codebase (this correlates with MINOR in semantic versioning),
  • BREAKING CHANGE: a commit that has a footer BREAKING CHANGE: introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,
  • types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
  • footers other than BREAKING CHANGE: <description> may be provided.

@mwestacott
Copy link
Contributor

Branch name will need to be changed from cc-259 to roe-2559.

@mwejuli-ch mwejuli-ch force-pushed the feat/cc-2559/save-sold-land-filter-option-to-database branch from c780041 to 99e6f32 Compare July 5, 2024 09:19
@mwejuli-ch mwejuli-ch force-pushed the feat/cc-2559/save-sold-land-filter-option-to-database branch from 99e6f32 to 0ab0482 Compare July 5, 2024 13:04
@mwejuli-ch mwejuli-ch closed this Jul 5, 2024
@mwejuli-ch mwejuli-ch deleted the feat/cc-2559/save-sold-land-filter-option-to-database branch July 5, 2024 13:05
@mwejuli-ch
Copy link
Contributor Author

mwejuli-ch commented Jul 5, 2024

@mwestacott - This PR was automatically closed after renaming in GitHub. Looks like there's no way of keeping the same PR after a branch rename.

The new PR is now here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants