ROE-2275 Proof of concept: Remove entity web page #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattch1
changed the title
markpit
reviewed
Jul 18, 2023
| "@companieshouse/node-session-handler": "^4.1.9", | ||
| "@companieshouse/structured-logging-node": "^1.0.8", | ||
| "@companieshouse/web-security-node": "^2.0.3", | ||
| "cookie-parser": "^1.4.6", | ||
| "express": "^4.17.3", | ||
| "express-validator": "^6.14.0", | ||
| "govuk-frontend": "^4.0.1", | ||
| "install": "^0.13.0", |
There was a problem hiding this comment.
i think the "npm" and "install" packages may have been added by accident, possibly by running 'npm install npm install' on the command line - so can probably be ignored if we use this POC in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://companieshouse.atlassian.net/browse/ROE-2275
Change description
Remove entity option web page part of the proof of concept.
Put remove code under update so as to separate the code but also indicate that we are not going to develop an entirely new Remove service in ROE and to use the Update service instead.
Work checklist
Merge instructions
We are committed to keeping commit history clean, consistent and linear. To achieve this, this commit should be structured as follows:
and contain the following structural elements:
BREAKING CHANGE:introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,fix:andfeat:are allowed, for examplebuild:,chore:,ci:,docs:,style:,refactor:,perf:,test:, and others,BREAKING CHANGE: <description>may be provided.