Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update conventional-changelog packages #4069

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: update conventional-changelog packages #4069

wants to merge 1 commit into from

Conversation

escapedcat
Copy link
Member

@escapedcat escapedcat commented May 7, 2024 •
edited
Loading

Update packages:

  • conventional-changelog-angular to v8
  • conventional-changelog-atom to v5
  • conventional-changelog-conventionalcommits to v8
  • conventional-commits-parser to v6

@JounQin I gave it a try and failed. If you find some time maybe you can have a look?

@escapedcat
feat: update conventional-changelog packages
c14945d 
BREAKING CHANGE: update all conventional-changelog packages

- conventional-changelog-angular to v8
- conventional-changelog-atom to v5
- conventional-changelog-conventionalcommits to v8
- conventional-commits-parser to v6
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat escapedcat mentioned this pull request May 10, 2024
Open
4 tasks
@effektsvk effektsvk mentioned this pull request Jun 7, 2024
Closed
@sheerlox
Copy link

sheerlox commented Jun 11, 2024 •
edited
Loading

From what I've observed on insurgent-lab/commitlint-config#99, upgrading conventional-changelog-conventionalcommits to v8 in config-conventional breaks the ! in commit titles:

validMessages: [
  'fix: some message',
  'refactor!: some message', // <- fails
  'fix(scope): some message',
  'fix(scope): some Message',
  'fix(scope): some message\n\nBREAKING CHANGE: it will be significant!',
  'fix(scope): some message\n\nbody',
  'fix(scope)!: some message\n\nbody', // <- fails
],

CI test run: https://github.com/insurgent-lab/commitlint-config/actions/runs/9463301740/job/26068172529

Example failure from @commitlint/cli:

⧗   input: refactor!: migrate to ESM

BREAKING CHANGE: the package is now pure ESM
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings

I'll stay on 7.0.2 for now, no big deal, I just wanted to add some potentially useful input here, especially since the failure in CI here isn't very helpful

sheerlox added a commit to insurgent-lab/commitlint-config that referenced this pull request Jun 11, 2024
@sheerlox
build(deps): pin dependency conventional-changelog-conventionalcommit…
99910cc 
…s to ^7.0.2

conventional-changelog/commitlint#4069 (comment)
sheerlox added a commit to insurgent-lab/commitlint-config that referenced this pull request Jun 11, 2024
@sheerlox
build(deps): pin dependency conventional-changelog-conventionalcommit…
7cdc4e5 
…s to ^7.0.2

conventional-changelog/commitlint#4069 (comment)
sheerlox pushed a commit to insurgent-lab/commitlint-config that referenced this pull request Jun 11, 2024
@semantic-release-bot
Release v20.0.0 [skip ci]
52a840c 
## [20.0.0](v19.0.0...v20.0.0) (2024-06-11)

### ⚠ Breaking changes

* the package is now pure ESM

### 🛠 Builds

* **deps:** pin dependency conventional-changelog-conventionalcommits to ^7.0.2 ([7cdc4e5](7cdc4e5)), closes [/github.com/conventional-changelog/commitlint/pull/4069#issuecomment-2160348473](https://github.com/insurgent-lab//github.com/conventional-changelog/commitlint/pull/4069/issues/issuecomment-2160348473)

### 📦 Code Refactoring

* migrate to ESM ([dbbb0db](dbbb0db))

### 🚨 Tests

* add valid message "refactor!: some message" ([51c0f18](51c0f18))
* fix commit-lint import ([cd6b9b0](cd6b9b0))

### ♻️ Chores

* commitlint peer-dependency version requirements ([5744a34](5744a34))
* **deps:** lock file maintenance ([650a7bf](650a7bf))
* **deps:** lock file maintenance ([85097d1](85097d1))
* **deps:** lock file maintenance ([f3f5f5e](f3f5f5e))
* **deps:** lock file maintenance ([c8c58fe](c8c58fe))
* **deps:** lock file maintenance ([7a2494f](7a2494f))
* **deps:** lock file maintenance ([d29e8c8](d29e8c8))
* **deps:** lock file maintenance ([e885767](e885767))
* **deps:** lock file maintenance ([0e73a94](0e73a94))
* **deps:** lock file maintenance ([fbcdccb](fbcdccb))
* **deps:** lock file maintenance ([5ac9f5d](5ac9f5d))
* **deps:** lock file maintenance ([1e53fd0](1e53fd0))
* **deps:** lock file maintenance ([973c7be](973c7be))
* **deps:** lock file maintenance ([070b560](070b560))
* **deps:** lock file maintenance ([c9e6ffe](c9e6ffe))
* **deps:** lock file maintenance ([1fbbe8c](1fbbe8c))
* **deps:** lock file maintenance ([141580f](141580f))
* **deps:** lock file maintenance ([98ecaae](98ecaae))
* **deps:** lock file maintenance ([f2296f4](f2296f4))
* **deps:** lock file maintenance ([21c3260](21c3260))
* **deps:** lock file maintenance ([5d48689](5d48689))
* **deps:** lock file maintenance ([d408d11](d408d11))
* **deps:** lock file maintenance ([4d392d2](4d392d2))
* **deps:** lock file maintenance ([314434a](314434a))
* **deps:** lock file maintenance ([33ba256](33ba256))
* **deps:** lock file maintenance ([c2afe7e](c2afe7e))
* **deps:** lock file maintenance ([85e2f13](85e2f13))
* **deps:** lock file maintenance ([60116d1](60116d1))
* **deps:** lock file maintenance ([6eb2e97](6eb2e97))
* **deps:** lock file maintenance ([042d73a](042d73a))
* **deps:** lock file maintenance ([36ab622](36ab622))
* **deps:** lock file maintenance ([e13e4e8](e13e4e8))
* **deps:** lock file maintenance ([9e13581](9e13581))
* **deps:** lock file maintenance ([379fa5b](379fa5b))
* **deps:** lock file maintenance ([190c42c](190c42c))
* **deps:** lock file maintenance ([2c183be](2c183be))
* **deps:** lock file maintenance ([b8219e6](b8219e6))
* **deps:** lock file maintenance ([55cde68](55cde68))
* **deps:** lock file maintenance ([79f2dbd](79f2dbd))
* **deps:** lock file maintenance ([e6d527b](e6d527b))
* **deps:** lock file maintenance ([9bcc706](9bcc706))
* **deps:** lock file maintenance ([23ce25d](23ce25d))
* **deps:** lock file maintenance ([8e821af](8e821af))
* **deps:** lock file maintenance ([fc24f7f](fc24f7f))
* **deps:** lock file maintenance ([3c60f9e](3c60f9e))
* **deps:** lock file maintenance ([29fcfc6](29fcfc6))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.2.0 ([cbebd1b](cbebd1b))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.4.1 ([496caa1](496caa1))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v9.2.2 ([88c11ca](88c11ca))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v9.2.3 ([1d0ecc0](1d0ecc0))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v9.2.4 ([a73318c](a73318c))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v9.2.6 ([cd69baa](cd69baa))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/npm to v11.0.1 ([11d636f](11d636f))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/npm to v11.0.3 ([c5fc55d](c5fc55d))
* **deps:** update dependency eslint to v8.53.0 ([#96](#96)) ([9d51bc3](9d51bc3))
* **deps:** update dependency eslint to v8.54.0 ([cc7e8d1](cc7e8d1))
* **deps:** update dependency eslint to v8.55.0 ([4861891](4861891))
* **deps:** update dependency eslint to v8.56.0 ([4c36fad](4c36fad))
* **deps:** update dependency eslint to v8.57.0 ([20e0e9c](20e0e9c))
* **deps:** update dependency eslint-config-prettier to v9.1.0 ([810011e](810011e))
* **deps:** update dependency eslint-plugin-jest to v27.6.0 ([4e3abee](4e3abee))
* **deps:** update dependency eslint-plugin-jest to v27.6.1 ([f368679](f368679))
* **deps:** update dependency eslint-plugin-jest to v27.8.0 ([8d36ad2](8d36ad2))
* **deps:** update dependency eslint-plugin-jest to v27.9.0 ([4ac50fb](4ac50fb))
* **deps:** update dependency eslint-plugin-prettier to v5.1.0 ([c5f9cdb](c5f9cdb))
* **deps:** update dependency eslint-plugin-prettier to v5.1.1 ([2dbea67](2dbea67))
* **deps:** update dependency eslint-plugin-prettier to v5.1.2 ([6013df4](6013df4))
* **deps:** update dependency prettier to v3.1.0 ([7a73ef4](7a73ef4))
* **deps:** update dependency prettier to v3.1.1 ([dd46397](dd46397))
* **deps:** update dependency prettier to v3.2.2 ([e3baf97](e3baf97))
* **deps:** update dependency prettier to v3.2.4 ([d645130](d645130))
* **deps:** update dependency prettier to v3.2.5 ([6cc7ee8](6cc7ee8))
* **deps:** update dependency prettier to v3.3.0 ([0b81a57](0b81a57))
* **deps:** update dependency prettier to v3.3.1 ([28e6ea0](28e6ea0))
* **deps:** update dependency semantic-release to v22.0.10 ([6e8f447](6e8f447))
* **deps:** update dependency semantic-release to v22.0.11 ([87ad06c](87ad06c))
* **deps:** update dependency semantic-release to v22.0.12 ([a8bef3a](a8bef3a))
* **deps:** update dependency semantic-release to v22.0.6 ([cd54f47](cd54f47))
* **deps:** update dependency semantic-release to v22.0.9 ([b489a2f](b489a2f))
* **deps:** update linters ([af8e476](af8e476))
* **deps:** update linters ([14f9028](14f9028))
* **deps:** update semantic-release related packages ([6566f65](6566f65))
* **deps:** update semantic-release related packages ([d65041e](d65041e))
* **deps:** update semantic-release related packages ([b8928e5](b8928e5))
* **deps:** update semantic-release related packages ([dca8a54](dca8a54))
* **deps:** update semantic-release related packages ([3391df1](3391df1))
* **deps:** update semantic-release related packages to v18.1.0 ([9fe6185](9fe6185))
* **deps:** update semantic-release related packages to v18.4.0 ([8066e7b](8066e7b))
* **deps:** update semantic-release related packages to v18.4.3 ([7a5fd9b](7a5fd9b))
* **deps:** update semantic-release related packages to v18.4.4 ([a7fd559](a7fd559))
* **deps:** update semantic-release related packages to v18.5.0 ([e619beb](e619beb))
* **deps:** update semantic-release related packages to v18.6.0 ([5345ad8](5345ad8))
* **deps:** update semantic-release related packages to v18.6.1 ([dabb9a2](dabb9a2))
@escapedcat escapedcat mentioned this pull request Jun 12, 2024
Open
1 task
@jasonschroeder-sfdc jasonschroeder-sfdc mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escapedcat @sheerlox