MySQL support #68
Open
MySQL support #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'key' alone is a reserved keyword in MySQL.
This is a (working) temporary solution based on SQL requests provided here: copycopter#64 (comment). Works for MySLQ and Postres; should be updated with ActiveRecord methods calls to be database agnostic.
The migration alters those fields to LONGTEXT. With TEXT, data were truncated. The :limit => 16777217 forces AR to use LONGTEXT.
|
I'd love to see code that doesn't have if statements based on the DB type. We should probably endeavor to either maintain PG solely or make the database calls generic enough to be supported by all/most DB's. Holding off merging for now. |
|
So, any plans on merging/developing this? We'd love if we were able to run the server against MySQL... |
|
All I know is i copied this into my own installation and it worked like a charm. Thanks for the patch Clarif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL support added. Still need to work on it, especially on the localization model which includes SQL requests for both MySQL and Postgres. But that works; might be useful for those of us willing to use this nice tool with their favorite DB server.