Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "onlyInvert" inversionAttempts option #148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LakeGH
Copy link

@LakeGH LakeGH commented Nov 14, 2019

Fixes #118.

shouldInvert should also be true if options.inversionAttempts equals "onlyInvert".

@LakeGH
Copy link
Author

LakeGH commented Nov 14, 2019

Definitely recommend squashing last three commits on merge! Was mostly playing around with the tslint config in this project.

ccinelli pushed a commit to ccinelli/jsQR that referenced this pull request Dec 30, 2019
danimoh added a commit to danimoh/jsQR that referenced this pull request Jul 9, 2020
Squashed commit of the following:

commit e7f282a
Author: LakeGH <[email protected]>
Date:   Thu Nov 14 13:29:15 2019 -0500

    Removing unneeded whitespace.

commit 13843e5
Author: LakeGH <[email protected]>
Date:   Thu Nov 14 13:14:50 2019 -0500

    Remove trailing whitespace for tslint

commit 4f3fef8
Author: LakeGH <[email protected]>
Date:   Thu Nov 14 13:12:12 2019 -0500

    Change order of inversionAttempts check for tslint

commit 0dfc578
Author: LakeGH <[email protected]>
Date:   Thu Nov 14 12:55:55 2019 -0500

    Fix "onlyInvert" inversionAttempts option.

    `shouldInvert` should also be true if `options.inversionAttempts` equals "onlyInvert".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onlyInvert mode doesn't work
1 participant