Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pacman version with php-fpm #426

Closed
wants to merge 2 commits into from
Closed

Fix pacman version with php-fpm #426

wants to merge 2 commits into from

Conversation

Meklad
Copy link

@Meklad Meklad commented Oct 29, 2023

  • Add to PhpFpm->getPhpVersion() new condition to check package manager to skip the version for some bistros, and return the version or null depend on the bistro.

  • The issue reference to this pull request: Bug: Issue with php8.2-fpm package name. #425

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jmarcher
jmarcher requested changes Dec 1, 2023
View reviewed changes
.phpunit.result.cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

cli/Valet/PhpFpm.php
*
* @return string|null
*/
public function getPhpVersion(): string|null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valet should work in PHP <8 (php >7.0) the return type is not required.

@arcanna
Copy link

arcanna commented Dec 17, 2023 •
edited
Loading

Can this fix be kindly merged in ASAP? Unable to install valet on Manjaro/Arch for 2 weeks now due to this php8.2-fpm error. Please advise if there is an alternate workaround. Reverted to using an older version for now.

coffeeneer
coffeeneer reviewed Dec 22, 2023
View reviewed changes
cli/Valet/PhpFpm.php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the using Pacman on line 10:

use Valet\PackageManagers\Pacman;

@jmarcher
Copy link
Collaborator

Can this fix be kindly merged in ASAP? Unable to install valet on Manjaro/Arch for 2 weeks now due to this php8.2-fpm error. Please advise if there is an alternate workaround. Reverted to using an older version for now.

This PR can not be merged as it is

@askdkc askdkc mentioned this pull request Jan 26, 2024
Closed
@askdkc askdkc mentioned this pull request Feb 6, 2024
Merged
@jmarcher jmarcher closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeeneer coffeeneer coffeeneer left review comments

@jmarcher jmarcher jmarcher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Meklad @arcanna @jmarcher @coffeeneer