Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another type error #24

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

mattstein
Copy link
Contributor

Description

I found another one! If you attempt to download an article preview, you’ll be greeted with this message:

Typed static property craft\applenews\Helper::$_htmlConverter must not be accessed before initialization

And to answer your question: yes, I insist on finding these one at a time.

Related issues

#22

@angrybrad angrybrad merged commit 6473b9b into craftcms:main Jun 2, 2023
10 checks passed
@mattstein mattstein deleted the fix/helper-type-error branch June 2, 2023 22:15
angrybrad added a commit that referenced this pull request Jun 2, 2023
@angrybrad
Copy link
Member

@mattstein thanks! i'll wait a week or so before cutting an official release in case you find more. :P

@mattstein
Copy link
Contributor Author

That’s fair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants