-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new database microservice API URL to the frontend #815
Conversation
Code Climate has analyzed commit 22661c7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 33.3% (70% is the threshold). This pull request will bring the total coverage in the repository to 35.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhodinemma, please merge into microservice
branch, not develop
🙏
I have tried testing this out but I can't seem to create any database, the page just reloads and nothing happens, any idea on what could be causing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For matters of configuration and independency, please create a database_axios
instance and have it handle the database API requests.
Having the backend axios instance handle database requests might become problematic in future.
You can base off this to see how that can be done.
Then you can do further modifications to some of the functions like handleGetRequest
That screenshot in the PR ain't magic...i was testing with my local database API instance. |
@rhodinemma please pick new changes from the microservice branch and add the environment variable in the file like shown in the link above to help with the deployments |
okay please, thank you |
Okay, so when should we look into this? |
today 👍🏾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The PR creates provision for the database API and modifies the database page functionality to interact with the database microservice API
Type of change.
Trello Ticket ID
https://trello.com/c/aBnLDgou
How Can This Been Tested?
Run this branch locally and checkout the
http://localhost:3000/projects/<projectID>/databases/
, validate the functionalities belowChecklist:
Screenshots