fx: change the logic for fetching activity logs #816
Conversation
khalifan-kfan
requested review from
Mubangizi,
rhodinemma,
LanternNassi and
KiraboIsaacBuyondo
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
src/apis/userActivityLoggerAxios.js
Outdated
| @@ -0,0 +1,28 @@ | |||
| import axios from "axios"; | |||
There was a problem hiding this comment.
Parsing error: require() of ES Module /usr/local/node_modules/eslint/node_modules/eslint-scope/lib/definition.js from /usr/local/node_modules/babel-eslint/lib/require-from-eslint.js not supported.
Instead change the require of definition.js in /usr/local/node_modules/babel-eslint/lib/require-from-eslint.js to a dynamic import() which is available in all CommonJS modules.
There was a problem hiding this comment.
Hey, @khalifan-kfan, instead of creating a new file and creating duplicate code, try to do something I did in the same axios file here
|
Hey Khalifan, let us merge into |
src/apis/userActivityLoggerAxios.js
Outdated
| @@ -0,0 +1,28 @@ | |||
| import axios from "axios"; | |||
There was a problem hiding this comment.
Hey, @khalifan-kfan, instead of creating a new file and creating duplicate code, try to do something I did in the same axios file here
| } | ||
|
|
||
| return axios | ||
| console.log(ACTIVITY_LOGS_API_URL) |
There was a problem hiding this comment.
I am not sure if this console logger is needed.
There was a problem hiding this comment.
Nice refactor @Mubangizi , this has been added, thank you
|
Code Climate has analyzed commit 6db10bf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 41.3% (70% is the threshold). This pull request will bring the total coverage in the repository to 35.4% (0.1% change). View more on Code Climate. |
Description
This PR is to change the base URL for activity logs to the new microservice URL
Type of change
Trello Ticket ID
https://trello.com/c/Gazjtbbq
How Can This Been Tested?
Run this application and add the environment variable
REACT_APP_ACTIVITY_LOGS_API_URLthat should be the base URL to the new app logger activitiesChecklist: