Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rasn fork that is fully compatible with no-std #126

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

koxu1996
Copy link
Contributor

kairos-tx is mainly based on rasn, ASN.1 library that claims to be no_std:

image

I recently discovered that it implicitly pulls std in 3 different ways - described in librasn/rasn#262.

Until it's fixed, I am proposing to use my fork - see changes here.

With this PR we get full no_std compatibility, proved with:

$ rustup target add thumbv7m-none-eabi
$ cargo build -p kairos-tx --no-default-features --target thumbv7m-none-eabi
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s

Copy link
Contributor

@Rom3dius Rom3dius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@koxu1996 koxu1996 merged commit 211d6e4 into main Jun 16, 2024
4 checks passed
@koxu1996 koxu1996 deleted the feature/kairos-tx-compatibile-with-no-std branch June 16, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants