Skip to content

Commit

Permalink
Fix viewport/height that was not being set during mobile runs (#1429)
Browse files Browse the repository at this point in the history
  • Loading branch information
jennifer-shehane authored Nov 14, 2023
1 parent 0e6602e commit 0bb3caa
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ commands:
steps:
- cypress/run-tests:
start-command: yarn start:ci
cypress-command: yarn cypress run --ci-build-id=<<parameters.ciBuildId>> --group="<<parameters.group>>" --record --parallel --spec=<<parameters.specPattern>> --browser=<<parameters.browser>> --config viewportWidth=375,viewportHeight=667
cypress-command: yarn cypress run --ci-build-id=<<parameters.ciBuildId>> --group="<<parameters.group>>" --record --parallel --spec=<<parameters.specPattern>> --browser=<<parameters.browser>> --config '{"e2e":{"viewportWidth":375,"viewportHeight":667}}'
- when:
condition:
and:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
- name: "UI Tests - Chrome - Mobile"
uses: cypress-io/github-action@v6
with:
config: "viewportWidth=375,viewportHeight=667"
config: "'{"e2e":{"viewportWidth":375,"viewportHeight":667}}"
start: yarn start:ci
wait-on: "http://localhost:3000"
wait-on-timeout: 120
Expand Down Expand Up @@ -236,7 +236,7 @@ jobs:
- name: "UI Tests - Firefox - Mobile"
uses: cypress-io/github-action@v6
with:
config: "viewportWidth=375,viewportHeight=667"
config: "'{"e2e":{"viewportWidth":375,"viewportHeight":667}}"
start: yarn start:ci
wait-on: "http://localhost:3000"
wait-on-timeout: 120
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,10 @@
"types": "tsc --noEmit",
"precypress:open": "yarn predev:cognito:ci",
"cypress:open": "cypress open",
"cypress:open:mobile": "cypress open --config viewportWidth=375,viewportHeight=667",
"cypress:open:mobile": "cypress open --config '{\"e2e\":{\"viewportWidth\":375,\"viewportHeight\":667}}'",
"cypress:run": "cypress run",
"cypress:run:component": "cypress run --component",
"cypress:run:mobile": "cypress run --config viewportWidth=375,viewportHeight=667",
"cypress:run:mobile": "cypress run --config '{\"e2e\":{\"viewportWidth\":375,\"viewportHeight\":667}}'",
"test": "yarn cypress:open",
"test:headless": "yarn cypress:run",
"test:api": "yarn cypress:run --spec 'cypress/tests/api/*'",
Expand Down

0 comments on commit 0bb3caa

Please sign in to comment.