Skip to content

Commit

Permalink
updating references to cypress config file to point to ts version
Browse files Browse the repository at this point in the history
  • Loading branch information
elylucas committed Jul 12, 2023
1 parent 44e4131 commit 7f9e394
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
# which has some compatibility issues with openSSL inside this windows job.
# Node 18 updated with OpenSSL provider which causes this compatibility issue
# downgrading node to v16 to use the openssl-legacy-provider by default to prevent this issue
node-version: '16.16.0'
node-version: "16.16.0"

- name: Cypress install
uses: cypress-io/github-action@v5
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
parallel: true
group: "UI - Chrome"
spec: cypress/tests/ui/*
config-file: cypress.config.js
config-file: cypress.config.ts
env:
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
Expand Down Expand Up @@ -160,7 +160,7 @@ jobs:
parallel: true
group: "UI - Chrome - Mobile"
spec: cypress/tests/ui/*
config-file: cypress.config.js
config-file: cypress.config.ts
env:
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
Expand Down Expand Up @@ -205,7 +205,7 @@ jobs:
parallel: true
group: "UI - Firefox"
spec: cypress/tests/ui/*
config-file: cypress.config.js
config-file: cypress.config.ts
env:
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
Expand Down Expand Up @@ -251,7 +251,7 @@ jobs:
parallel: true
group: "UI - Firefox - Mobile"
spec: cypress/tests/ui/*
config-file: cypress.config.js
config-file: cypress.config.ts
env:
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
Expand All @@ -277,7 +277,7 @@ jobs:
uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16.16.0'
node-version: "16.16.0"

- name: Download the build folders
uses: actions/download-artifact@v3
Expand All @@ -295,7 +295,7 @@ jobs:
parallel: true
group: "UI - Electron - Windows"
spec: cypress/tests/ui/*
config-file: cypress.config.js
config-file: cypress.config.ts
env:
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ yarn cypress:open

> 🚩 **Note**
>
> If you have changed the default ports, then you need to update Cypress configuration file (`cypress.config.js`) locally.
> There are three properties that you need to update in `cypress.config.js`: `e2e.baseUrl`, `env.apiUrl`, and `env.url`.
> If you have changed the default ports, then you need to update Cypress configuration file (`cypress.config.ts`) locally.
> There are three properties that you need to update in `cypress.config.ts`: `e2e.baseUrl`, `env.apiUrl`, and `env.url`.
> The port number in `e2e.baseUrl` corresponds to `PORT` variable in `.env` file. Similarly, the port number in `env.apiUrl` and `env.url` correspond to `VITE_BACKEND_PORT`.
> For example, if you have changed `PORT` to `13000` and `VITE_BACKEND_PORT` to `13001` in `.env` file, then your `cypress.config.js` should look similar to the following snippet:
> For example, if you have changed `PORT` to `13000` and `VITE_BACKEND_PORT` to `13001` in `.env` file, then your `cypress.config.ts` should look similar to the following snippet:
>
> ```js
> {
Expand All @@ -133,7 +133,7 @@ yarn cypress:open
> }
> ```
>
> Avoid committing the modified `cypress.config.js` into Git since the CI environments still expect the application to be run on default ports.
> Avoid committing the modified `cypress.config.ts` into Git since the CI environments still expect the application to be run on default ports.
## Tests
Expand Down

0 comments on commit 7f9e394

Please sign in to comment.