fix: update cypress logo on login page #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Passing run #6208 ↗︎
Details:
Review all test suite changes for PR #1436 ↗︎ |
|||||||||||||||
jennifer-shehane
approved these changes
Nov 27, 2023
ryanjwilke
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
@elevatebart Looks good to me.
One recommendation that I would have is that I do feel like our logo should probably be coming from our Design System as well. I wouldn't block on that here, but I do think it would be worthwhile pulling from a central source of truth for these types of assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After