chore: update RWA to make running locally easier #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can go between e2e and ct at the same time
cacieprins
requested changes
Mar 11, 2024
cacieprins
approved these changes
Mar 11, 2024
Passing run #6363 ↗︎
Details:
Review all test suite changes for PR #1524 ↗︎ |
|||||||||||||||
1 task
|
markerikson
pushed a commit
to replayio-public/cypress-realworld-app
that referenced
this pull request
Jun 25, 2024
* chore: fix typings issues from yarn start when starting the backend dev server * reseed data as test shouldnt fail for new users * fix aws exports not failing RWA if missing * use @cypress/vite-dev-server to use different port from app so users can go between e2e and ct at the same time * fix types * run prettier * fix unit tests * fix linting issue by breaking chainable up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after running the RWA earlier this week that there were some typing, linting, and other issues that make the app somewhat difficult to run locally. This PR addresses the typing issues, dependency issues, and old scaffolded data.
I had to downgrade
passportdue to jaredhanson/passport#904