Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all scrap metadata survives round trip from th2 to WTherion to json and back #7

Open
CaverBruce opened this issue Jul 27, 2022 · 1 comment

Comments

@CaverBruce
Copy link

Original scrap definition in th2:

scrap 3-HawkesPlan-s1 -projection plan -station-names []@3 -author 2022.05.06 "B Mutton" -copyright 2022 NZSS -scale [0 0 787.4 787.4 0 0 10 10 m]

Scrap definition in resultant th2:

scrap 3-HawkesPlan-s1 -scale [0 0 787.4 787.4 0 0 10 10 m] -projection "plan" -author "2022.05.06" -copyright "2022" undefined -station-names []@3

-author is missing the author's name
-copyright is missing the copyrighter's name (becomes 'undefined').

There may be an issue with data type also (string instead of date).

@CaverBruce
Copy link
Author

Checked as discussed in #11 (to be posted soon)
Original scrap definition in th2:
scrap 3-HawkesPlan-s1 -projection plan -station-names []@3 -author 2022.05.06 "B Mutton" -copyright 2022 NZSS -scale [0 0 787.4 787.4 0 0 10 10 m]

Scrap definition in resultant th2:
scrap 3-HawkesPlan-s1 -scale [0 0 787.4 787.4 0 0 10 10 m] -projection "plan" -author "2022.05.06 "B Mutton" -copyright "2022 NZSS" -station-names []@3

  • author has inappropriate (and unclosed) quote at start of date field (should be deleted)
  • copyright has inappropriate quote at start of date field (should be moved to start of text field)

daem-on added a commit that referenced this issue Dec 27, 2022
Change `trimEnclosing` implementation, fix `-scale` to fit specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant