Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding retries and workaround to mlflow integration to alleviate… #22718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JPercivall
Copy link

… 429 issues (22633)

Summary & Motivation

The mlflow qps for searches is very low and if you have a flow with multiple ops run in docker containers that you run in parallel you quickly hit the qps. This adds retries and a secondary method to avoid searching for the run ids multiple times in a run.

How I Tested These Changes

I added units tests. Also I deployed a version locally which I tested with a sensor and jobs that I created to interface with mlflow. I tested passing the run_id in the resource dynamically and letting the resource create it.

Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @JPercivall. And for your patience in us getting to it.

A couple notes:

Lastly, is my understanding accurate that there are a few separate changes in here?

  • Adding retry logic when searching for runs
  • Adding mlflow run ID
  • Adding mlruns to .gitignore

If we were making this changes, we would probably separate these out into separate PRs. Not required, but a suggestion to consider.

@JPercivall
Copy link
Author

Hey @sryza! Thank you for unblocking the CI and I will get on fixing the type issues.

Ah, I knew y'all had imported tenacity but didn't realize you already had a backoff util. I will update.

Yeah, the changes are relatively distinct, but they all relate to the original #22633 issue, so I figured I'd put them in one. I'm happy to separate them into multiple PRs.

I should have these changes together by the end of next week.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlflow integration causes 429 error responses from Databricks when running multiple parallel jobs/ops
2 participants