Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_local_io for windows #695

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Fix test_local_io for windows #695

merged 7 commits into from
Jul 8, 2024

Conversation

parthban-db
Copy link
Contributor

Changes

Fix tests/integration/test_files.py::test_local_io for windows. This PR is part of fixing the test for windows

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@parthban-db parthban-db requested a review from mgyucht July 4, 2024 07:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details.

Running from downstreams #264

mgyucht
mgyucht approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@parthban-db parthban-db added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 881670f Jul 8, 2024
8 of 13 checks passed
@parthban-db parthban-db deleted the parthban-db/windows-test branch July 8, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parthban-db @mgyucht