Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add DataPlane support #700

Merged
merged 12 commits into from
Jul 16, 2024
Merged

[Feature] Add DataPlane support #700

merged 12 commits into from
Jul 16, 2024

Conversation

hectorcast-db
Copy link
Contributor

Changes

Add DataPlane support

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied
  • Manual test against staging workspace (prod workspaces don't support DataPlane APIs)

@hectorcast-db hectorcast-db changed the title Add DataPlane support [Feature] Add DataPlane support Jul 15, 2024
mgyucht
mgyucht reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, otherwise basically looks good to me!

.codegen/service.py.tmpl Show resolved Hide resolved
databricks/sdk/core.py Show resolved Hide resolved
databricks/sdk/core.py Outdated Show resolved Hide resolved
databricks/sdk/data_plane.py Show resolved Hide resolved
databricks/sdk/data_plane.py Show resolved Hide resolved
.codegen/service.py.tmpl Outdated Show resolved Hide resolved
@mgyucht mgyucht added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 3009a6b Jul 16, 2024
14 checks passed
@mgyucht mgyucht deleted the dataplane-support branch July 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hectorcast-db @mgyucht