Build fixes #213

ronanstokes-db · 2023-05-09T19:01:58Z

Proposed changes

Fixes for development build process

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Change to tutorials, tests or examples
Non code change (readme, images or other non-code assets)
Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
Any dependent changes have been merged and published in downstream modules
Submission does not reduce code coverage numbers
Submission does not increase alerts or messages from prospector / lint

Further comments

A recent change to the package rst2pdf causes the build to fail. However as this is not used in building wheel or docs, we can remove it from the build environment.

merged from remote

merged of changes from remote

merged in upstream changes

merge from remote

merge from upstream

merge from remote

codecov · 2023-05-09T19:44:20Z

Codecov Report

Merging #213 (c81cc66) into master (80ca02b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files          23       23           
  Lines        2680     2680           
  Branches      452      452           
=======================================
  Hits         2465     2465           
  Misses        128      128           
  Partials       87       87

Impacted Files	Coverage Δ
dbldatagen/_version.py	`100.00% <100.00%> (ø)`

* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * updated build version * updated build version

* wip * wip * changes for release * example notebook * updates to handle shared spark session restrictions * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * updates to handle shared sparkSession * changes per code review * Doc updates 032223 (#180) * wip * wip * wip * wip * wip * wip * wip wip Doc updates 032523 (#181) * wip * documentation updates Feature build ordering improvements 2 (#189) * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * improved build ordering * improved build ordering * improved build ordering * reverted unnecessary changes * reverted unnecessary changes * udated ColumnSpecOptions description Feature consistency fixes (#182) * fixed use of time strings to allow both and etc * fixed use of time strings to allow both 'seconds' and 'second' etc * id column fixes Doc updates 100522 (#119) * fixed reference to dbx in pull_request_template * reverted inadvertently changed file * release 0.2.1 * doc updates * doc updates * updates for building docs * updated public docs * updated sphinx version * updated docs * doc updates * removed generated docs * removed changes to non-doc * reverted inadvertently changed file * release 0.2.1 * doc updates doc updates * tidied up makefile * added workflow action to update tag 'preview' * develop branch updates * revised unit tests to use parameterized approach * changed utils tests to pytest * changed changelog format * changelog changes * changelog updates from merge * update to change as a resultt of merge of time fixes * updates for test speed improvements * updated tests * updated tests * updated tests * updated tests * fixed typo * reverted pytest changes - separate feature * reverted pytest changes - separate feature * reverted pytest changes - separate feature * reverted pytest changes - separate feature * changed partitioning to run more efficiently on github runner * changed partitioning to run more efficiently on github runner * changed partitioning to run more efficiently on github runner * changed partitioning to run more efficiently on github runner * changed partitioning to run more efficiently on github runner * use as query name for spark instance * wip * wip * wip * wip * wip * wip * wip * Updates to template text generation for better performance and repeatable text generation * Updates to template text generation for better performance and repeatable text generation * reverted unrelated changes * added further coverage tests and renamed option fromn 'seedColumn' to 'seedColumnName' for clarity * added further coverage test for 'seedColumnName' property' * additional test coverage * updated tests for ILText generation * updated tests for ILText generation * merged changes from master * change to test potential break in build process * updated build process to explicotly use python 3.8 * added explicit python version setup to build * changes to build actions * reverted changes to master + build action changes * remerged repeatable feature generation * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * changed table formatting in TemplateGenerator doc string * changed table formatting in TemplateGenerator doc string * updates from master * updates to develop * dont update coverage when pushing to develop * Feature docs v34 (#197) * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * doc changes only * wip * wip * Update generating_column_data.rst * Update generating_json_data.rst * wip * new document build * adjusted comment banner at start of each doc file * updated build * wip * wip * wip * wip * wip * wip * wip * reverted code comment changes * merge Feature ordering improvements2 into develop (#198) * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * improved build ordering * improved build ordering * improved build ordering * reverted unnecessary changes * reverted unnecessary changes * reverted inadvertent merge * Revert "Merge branch 'develop' into feature_consistency_fixes" This reverts commit e0efc4e, reversing changes made to a263bd9. Feature docs v34 v2 (#192) * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * doc changes only * wip * wip * Update generating_column_data.rst * Update generating_json_data.rst * wip * new document build * adjusted comment banner at start of each doc file * updated build * wip * wip * wip * wip * wip * wip * wip * reverted code comment changes * wip * Feature v34 (#201) * wip * prep for release * prep for release * wip * Feature generate from existing data (#163) * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Remove calls to root logger. (#205) * Release v34post1 (#206) * wip * hotfix release for logger fixes * fix for root logger configuration * Fix doc typos and minor clarification (#207) * wip * wip * wip * Feature issue 209 (#210) * wip * wip * wip * Release 0v34post2 (#211) * wip * wip * Feature html formatting (#208) * wip * wip * wip * wip * wip * wip * Build fixes (#213) * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * updated build version * updated build version * Feature doc change generating text (#218) * wip * wip * wip * updated running of prospector * Feature build update (#220) * wip * wip * updates to handle changes in upstream pipenv package * updated build version * Feature struct changes (#219) * wip * wip * added support for inferred types * added support for inferred types * wip * wip * wip * updates and fixes to unit tests * wip * updated pipfile due to upstream changes in pipenv * additional tests * wip * wip * wip * wip * removed old code * Feature additional docs (#222) * wip * wip * doc updates * function doc changes only * function doc changes only * changes for release * example notebook * Feature readme updates - updates readme to note compatible Unity Catalog releases (#236) * wip * wip * changes for release * example notebook * updated readme to note compatible unity catalog runtimes * updated readme to note compatible unity catalog runtimes * updated readme to note compatible unity catalog runtimes * updated readme to note compatible unity catalog runtimes * Feature add codeowners (#238) * Test assign (#239) * updates to handle shared spark session restrictions * Update LICENSE (#246) * updates to handle shared sparkSession * changes per code review --------- Co-authored-by: Marvin Schenkel <[email protected]> Co-authored-by: Serge Smertin <[email protected]>

ronanstokes-db added 12 commits March 25, 2023 17:18

wip

aebbb06

merge from origin

5f0ffc0

wip

1eda552

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

7de014c

merged from remote

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

c859475

merged of changes from remote

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

3094e96

merged in upstream changes

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

3bf6e9b

merge from remote

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

caaff18

merge from remote

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

87d5c50

merge from remote

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

4536794

merge from upstream

Merge branch 'master' of https://github.com/databrickslabs/dbldatagen

eba6193

merge from remote

wip

c4fdc3b

ronanstokes-db requested a review from howardwu-db May 9, 2023 19:02

ronanstokes-db self-assigned this May 9, 2023

ronanstokes-db added bug Something isn't working Build process improvement labels May 9, 2023

ronanstokes-db added this to the v0.3.4 milestone May 9, 2023

ronanstokes-db added 10 commits May 9, 2023 12:07

wip

46969e7

wip

cf9e909

wip

ba929ac

wip

03245c3

wip

4b94465

wip

ff1574c

wip

97616ed

wip

064ab0a

wip

613bf9c

wip

1b90eb3

howardwu-db approved these changes May 9, 2023

View reviewed changes

updated build version

65f4d54

updated build version

c81cc66

ronanstokes-db merged commit 250f92a into master May 9, 2023
4 checks passed

ronanstokes-db deleted the build_fixes branch May 9, 2023 20:24

ronanstokes-db added a commit that referenced this pull request Feb 17, 2024

Build fixes (#213)

c01baa3

* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * updated build version * updated build version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build fixes #213

Build fixes #213

ronanstokes-db commented May 9, 2023 •

edited

Loading

codecov bot commented May 9, 2023 •

edited

Loading

Build fixes #213

Build fixes #213

Conversation

ronanstokes-db commented May 9, 2023 • edited Loading

Proposed changes

Types of changes

Checklist

Further comments

codecov bot commented May 9, 2023 • edited Loading

Codecov Report

ronanstokes-db commented May 9, 2023 •

edited

Loading

codecov bot commented May 9, 2023 •

edited

Loading